[PATCH] D54939: [llvm-objcopy] Initial COFF support

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo updated this revision to Diff 177481.
mstorsjo retitled this revision from "[RFC] [llvm-objcopy] Initial COFF support" to "[llvm-objcopy] Initial COFF support".
mstorsjo added a comment.

Removed the RFC tag as it has been through a few rounds of discussion already, and I'd like to see actual progress towards getting it merged.

I changed the tests to use yaml files as input as requested. In order to have sensible tests that actually check that the file as a whole is copied correctly, without tediously writing lots of individual CHECK lines for llvm-readobj+FileCheck, I'm using obj2yaml on both inputs and outputs, and a plain cmp on the output from obj2yaml. Later patches that actually do some transformation can of course use more specific and targeted checks with llvm-readobj+FileCheck.

Ping @rnk, can you give this a review from a generic COFF perspective?

Ping @alexshap, do you have time to have a look?

Ping @jakehehrlich, can you follow-up on the discussion where you suggested renaming fields? Can you, if possible, have a look on the patch as a whole, wrt to how I read structs from the input file, keeping them mostly packed in the same kinds of structs as in the binary file.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54939/new/

https://reviews.llvm.org/D54939

Files:
  include/llvm/Object/COFF.h
  lib/Object/COFFObjectFile.cpp
  test/tools/llvm-objcopy/COFF/Inputs/i386-exe.yaml
  test/tools/llvm-objcopy/COFF/Inputs/i386-obj.yaml
  test/tools/llvm-objcopy/COFF/Inputs/x86_64-exe.yaml
  test/tools/llvm-objcopy/COFF/Inputs/x86_64-obj.yaml
  test/tools/llvm-objcopy/COFF/basic-copy.test
  tools/llvm-objcopy/CMakeLists.txt
  tools/llvm-objcopy/COFF/COFFObjcopy.cpp
  tools/llvm-objcopy/COFF/COFFObjcopy.h
  tools/llvm-objcopy/COFF/Object.cpp
  tools/llvm-objcopy/COFF/Object.h
  tools/llvm-objcopy/llvm-objcopy.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D54939.177481.patch
Type: text/x-patch
Size: 54047 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181210/7cdaa0ec/attachment-0001.bin>