[PATCH] D55473: [Sanitizer] expand sysctl/getmntinfo/nl_langinfo to Darwin

Kamil Rytarowski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 10 01:26:57 PST 2018


krytarowski added a comment.

In D55473#1325096 <https://reviews.llvm.org/D55473#1325096>, @devnexen wrote:

> In D55473#1325082 <https://reviews.llvm.org/D55473#1325082>, @krytarowski wrote:
>
> > > In fact I had to fix that way to make it work under Darwin. With this check-sanitiser passes.
> >
> > I don't like this hack, please find a cleaner solution.
>
>
> Or why not putting the NetBSD part into NetBSD folder (anyway these interceptors are distinguished too) what do you think ?


I think that this is a good idea too.

asysctl.cc and sysctlgetmibinfo.cc


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55473/new/

https://reviews.llvm.org/D55473





More information about the llvm-commits mailing list