[PATCH] D55218: [ELF] - Allow discarding .dynsym from the linker script.
George Rimar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Dec 10 01:16:55 PST 2018
This revision was automatically updated to reflect the committed changes.
Closed by commit rLLD348748: [ELF] - Allow discarding .dynsym from the linker script. (authored by grimar, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D55218?vs=176398&id=177469#toc
Repository:
rLLD LLVM Linker
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55218/new/
https://reviews.llvm.org/D55218
Files:
ELF/LinkerScript.cpp
ELF/SyntheticSections.cpp
test/ELF/linkerscript/discard-section-err.s
Index: ELF/LinkerScript.cpp
===================================================================
--- ELF/LinkerScript.cpp
+++ ELF/LinkerScript.cpp
@@ -415,8 +415,8 @@
void LinkerScript::discard(ArrayRef<InputSection *> V) {
for (InputSection *S : V) {
- if (S == In.ShStrTab || S == In.Dynamic || S == In.DynSymTab ||
- S == In.RelaDyn || S == In.RelrDyn)
+ if (S == In.ShStrTab || S == In.Dynamic || S == In.RelaDyn ||
+ S == In.RelrDyn)
error("discarding " + S->Name + " section is not allowed");
// You can discard .hash and .gnu.hash sections by linker scripts. Since
Index: ELF/SyntheticSections.cpp
===================================================================
--- ELF/SyntheticSections.cpp
+++ ELF/SyntheticSections.cpp
@@ -1508,7 +1508,10 @@
// relocations due to IFUNC (e.g. strcpy). sh_link will be set to 0 in that
// case.
InputSection *SymTab = Config->Relocatable ? In.SymTab : In.DynSymTab;
- getParent()->Link = SymTab ? SymTab->getParent()->SectionIndex : 0;
+ if (SymTab && SymTab->getParent())
+ getParent()->Link = SymTab->getParent()->SectionIndex;
+ else
+ getParent()->Link = 0;
if (In.RelaIplt == this || In.RelaPlt == this)
getParent()->Info = In.GotPlt->getParent()->SectionIndex;
@@ -2126,7 +2129,8 @@
}
void GnuHashTableSection::finalizeContents() {
- getParent()->Link = In.DynSymTab->getParent()->SectionIndex;
+ if (OutputSection *Sec = In.DynSymTab->getParent())
+ getParent()->Link = Sec->SectionIndex;
// Computes bloom filter size in word size. We want to allocate 12
// bits for each symbol. It must be a power of two.
@@ -2256,7 +2260,8 @@
}
void HashTableSection::finalizeContents() {
- getParent()->Link = In.DynSymTab->getParent()->SectionIndex;
+ if (OutputSection *Sec = In.DynSymTab->getParent())
+ getParent()->Link = Sec->SectionIndex;
unsigned NumEntries = 2; // nbucket and nchain.
NumEntries += In.DynSymTab->getNumSymbols(); // The chain entries.
Index: test/ELF/linkerscript/discard-section-err.s
===================================================================
--- test/ELF/linkerscript/discard-section-err.s
+++ test/ELF/linkerscript/discard-section-err.s
@@ -12,10 +12,9 @@
# RUN: FileCheck -check-prefix=DYNAMIC %s
# DYNAMIC: discarding .dynamic section is not allowed
+## We allow discarding .dynsym, check we don't crash.
# RUN: echo "SECTIONS { /DISCARD/ : { *(.dynsym) } }" > %t.script
-# RUN: not ld.lld -pie -o %t --script %t.script %t.o 2>&1 | \
-# RUN: FileCheck -check-prefix=DYNSYM %s
-# DYNSYM: discarding .dynsym section is not allowed
+# RUN: ld.lld -pie -o %t --script %t.script %t.o
## We allow discarding .dynstr, check we don't crash.
# RUN: echo "SECTIONS { /DISCARD/ : { *(.dynstr) } }" > %t.script
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D55218.177469.patch
Type: text/x-patch
Size: 2819 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181210/3d075135/attachment.bin>
More information about the llvm-commits
mailing list