[PATCH] D55216: [bugpoint][PR29027] Reduce function attributes
Brian Gesiak via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Dec 9 10:21:22 PST 2018
modocache marked 3 inline comments as done.
modocache added inline comments.
================
Comment at: tools/bugpoint/CrashDebugger.cpp:333
+ Expected<TestResult> doTest(std::vector<Attribute> &Prefix,
+ std::vector<Attribute> &Kept) override {
+ if (!Kept.empty() && TestFuncAttrs(Kept))
----------------
reames wrote:
> It probably makes more sense to call this Suffix?
I agree, but every other implementation of `doTest` names this `Kept`... maybe we can rename them all in a future NFC commit?
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55216/new/
https://reviews.llvm.org/D55216
More information about the llvm-commits
mailing list