[llvm] r348728 - [X86] Add some comments about when some X86 intrinsic autoupgrade code was added.

Craig Topper via llvm-commits llvm-commits at lists.llvm.org
Sun Dec 9 10:02:40 PST 2018


Author: ctopper
Date: Sun Dec  9 10:02:40 2018
New Revision: 348728

URL: http://llvm.org/viewvc/llvm-project?rev=348728&view=rev
Log:
[X86] Add some comments about when some X86 intrinsic autoupgrade code was added.

Someday we'd like to remove old autoupgrade code so it helps to annotate how long its been there so we don't have to go digging through commit history.

Modified:
    llvm/trunk/lib/IR/AutoUpgrade.cpp

Modified: llvm/trunk/lib/IR/AutoUpgrade.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/IR/AutoUpgrade.cpp?rev=348728&r1=348727&r2=348728&view=diff
==============================================================================
--- llvm/trunk/lib/IR/AutoUpgrade.cpp (original)
+++ llvm/trunk/lib/IR/AutoUpgrade.cpp Sun Dec  9 10:02:40 2018
@@ -382,20 +382,20 @@ static bool UpgradeX86IntrinsicFunction(
     return true;
   }
 
-  if (Name == "addcarryx.u32")
+  if (Name == "addcarryx.u32") // Added in 8.0
     return UpgradeADCSBBIntrinsic(F, Intrinsic::x86_addcarryx_u32, NewFn);
-  if (Name == "addcarryx.u64")
+  if (Name == "addcarryx.u64") // Added in 8.0
     return UpgradeADCSBBIntrinsic(F, Intrinsic::x86_addcarryx_u64, NewFn);
-  if (Name == "addcarry.u32")
+  if (Name == "addcarry.u32") // Added in 8.0
     return UpgradeADCSBBIntrinsic(F, Intrinsic::x86_addcarry_u32, NewFn);
-  if (Name == "addcarry.u64")
+  if (Name == "addcarry.u64") // Added in 8.0
     return UpgradeADCSBBIntrinsic(F, Intrinsic::x86_addcarry_u64, NewFn);
-  if (Name == "subborrow.u32")
+  if (Name == "subborrow.u32") // Added in 8.0
     return UpgradeADCSBBIntrinsic(F, Intrinsic::x86_subborrow_u32, NewFn);
-  if (Name == "subborrow.u64")
+  if (Name == "subborrow.u64") // Added in 8.0
     return UpgradeADCSBBIntrinsic(F, Intrinsic::x86_subborrow_u64, NewFn);
 
-  if (Name == "rdtscp") {
+  if (Name == "rdtscp") { // Added in 8.0
     // If this intrinsic has 0 operands, it's the new version.
     if (F->getFunctionType()->getNumParams() == 0)
       return false;




More information about the llvm-commits mailing list