[PATCH] D55435: [AMDGPU] Fix discarded result of addAttribute

Brian Gesiak via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Dec 9 08:15:03 PST 2018


modocache marked an inline comment as done.
modocache added inline comments.


================
Comment at: test/CodeGen/AMDGPU/simplify-libcalls.ll:790
+
 ; CGN-PRELINK: attributes #[[$NOUNWIND]] = { nounwind }
+; GCN-PRELINK: attributes #[[NOUNWIND_READONLY]] = { nounwind readonly }
----------------
My original diff fixed the typo in this check statement -- this should be `GCN-PRELINK`, not `CGN-PRELINK`. But in the interest of keeping this patch small and only changing one thing at a time, I've left this line alone for now. For what it's worth, the tests do pass with this typo fixed so that the CHECK is actually run.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55435/new/

https://reviews.llvm.org/D55435





More information about the llvm-commits mailing list