[PATCH] D38028: [X86][TableGen] Recommitting the X86 memory folding tables TableGen backend while disabling it by default.

Sun Dec 9 06:01:12 PST 2018

thakis added a comment.

In D38028#1324584 <https://reviews.llvm.org/D38028#1324584>, @RKSimon wrote:

> In D38028#1324542 <https://reviews.llvm.org/D38028#1324542>, @thakis wrote:
>
> > In D38028#1324522 <https://reviews.llvm.org/D38028#1324522>, @craig.topper wrote:
> >
> > > You're correct, nothing sets it. I'm nervous about ever using the autogenerated table by default. I've used it a while back to copy entries into the manual tables. But I had to add more waivers and adjustments to fix bugs in the autogenerated table in the process. I don't think they are still a perfect match. I worry that if we switch to the autogenerated table and as we add new instructions in the future we can silently introduce bugs because the new table entries weren't reviewed.
> >
> >
> > Should we remove the autogenerated table again then?
>
>
> It still has merit as a debugging tool to check against the manually created tables - not sure if that's a big enough reason?

Up to the folks using it :-) Out of curiosity, when you do this checking, do you manually run tablegen, or do you set this cmake var somehow?

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D38028/new/

https://reviews.llvm.org/D38028