[PATCH] D55481: [CostModel][X86] Have getArithmeticReductionCost call back to the target code after the loop reaches a legal type. Only handle legal/simple types from the X86 code

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Dec 9 02:48:56 PST 2018


RKSimon added inline comments.


================
Comment at: include/llvm/CodeGen/BasicTTIImpl.h:1426
         LT.second.isVector() ? LT.second.getVectorNumElements() : 1;
-    while (NumVecElts > MVTLen) {
-      NumVecElts /= 2;
-      Ty = VectorType::get(ScalarTy, NumVecElts);
+    if (NumVecElts > MVTLen) {
+      do {
----------------
Please add a comment describing how this is supposed to work (similar to the patch's summary).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55481/new/

https://reviews.llvm.org/D55481





More information about the llvm-commits mailing list