[PATCH] D38028: [X86][TableGen] Recommitting the X86 memory folding tables TableGen backend while disabling it by default.

[Craig Topper via Phabricator via llvm-commits]

craig.topper added a comment.

You're correct, nothing sets it. I'm nervous about ever using the autogenerated table by default. I've used it a while back to copy entries into the manual tables. But I had to add more waivers and adjustments to fix bugs in the autogenerated table in the process. I don't think they are still a perfect match. I worry that if we switch to the autogenerated table and as we add new instructions in the future we can silently introduce bugs because the new table entries weren't reviewed.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D38028/new/

https://reviews.llvm.org/D38028