[PATCH] D55368: [Sanitizer] capsicum api subset interception

[Kamil Rytarowski via Phabricator via llvm-commits]

krytarowski added inline comments.


================
Comment at: lib/sanitizer_common/CMakeLists.txt:22
   sanitizer_persistent_allocator.cc
+  sanitizer_platform_limits_freebsd.cc
   sanitizer_platform_limits_linux.cc
----------------
vitalybuka wrote:
> krytarowski wrote:
> > I recommend to split freebsd entirely from linux.cc, but as a separate commit.
> Unrelated, but also we need to consider extracting platform specific interceptors from sanitizer_common_interceptors.inc 
> 
> 
I don't think that this is a good idea to split sanitizer_common_interceptors.inc. I'm adding interceptors for NetBSD, but a lot of them are valid for other BSDs/GNU/Darwin and almost all of them for OSes like Minix (if it will ever get sanitizers). Once OpenBSD will join (if ever), it will be closer to NetBSD than FreeBSD.


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55368/new/

https://reviews.llvm.org/D55368