[PATCH] D55446: Show "Unknown -z option" error message early.

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 7 16:49:21 PST 2018


thakis accepted this revision.
thakis added a comment.
This revision is now accepted and ready to land.

Patch LGTM, but the description looks wrong to me:



================
Comment at: lld/test/ELF/driver.test:62
 
 # RUN: not ld.lld %t -z foo 2>&1 | FileCheck -check-prefix=ERR10 %s
+# RUN: not ld.lld %t -z foo --version 2>&1 | FileCheck -check-prefix=ERR10 %s
----------------
This test suggests that the patch description isn't quite right -- lld already prints an error for unknown -z flags. The only effect this patch has is that it now also does this if --version or --help is passed, right?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55446/new/

https://reviews.llvm.org/D55446





More information about the llvm-commits mailing list