[PATCH] D55368: [Sanitizer] capsicum api subset interception

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka requested changes to this revision.
vitalybuka added inline comments.
This revision now requires changes to proceed.


================
Comment at: lib/sanitizer_common/sanitizer_common_interceptors.inc:7746
+  if (rights)
+    COMMON_INTERCEPTOR_WRITE_RANGE(ctx, rights, sizeof(*rights));
+
----------------
we expect writes only if function succeeded?

```
int ret = REAL(cap_rights_get)(fd, rights);
if (!ret && rights)
    COMMON_INTERCEPTOR_WRITE_RANGE(ctx, rights, sizeof(*rights));
return ret;
```


================
Comment at: lib/sanitizer_common/sanitizer_common_interceptors.inc:7764
+  if (cmds)
+    COMMON_INTERCEPTOR_WRITE_RANGE(ctx, cmds, sizeof(*cmds) * maxcmds);
+
----------------
write on success only


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55368/new/

https://reviews.llvm.org/D55368