[PATCH] D55031: Add a new interceptors for statvfs1(2) and fstatvfs1(2) from NetBSD
Kamil Rytarowski via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Dec 7 14:28:20 PST 2018
krytarowski marked an inline comment as done.
krytarowski added inline comments.
================
Comment at: lib/sanitizer_common/sanitizer_common_interceptors.inc:4275
COMMON_INTERCEPTOR_ENTER(ctx, fstatvfs, fd, buf);
+ COMMON_INTERCEPTOR_FD_ACCESS(ctx, fd);
// FIXME: under ASan the call below may write to freed memory and corrupt
----------------
vitalybuka wrote:
> krytarowski wrote:
> > vitalybuka wrote:
> > > Please check RAW DIFF https://reviews.llvm.org/file/data/x5p222jqqe67lsydfoh3/PHID-FILE-dwwqavhtcbz2oecylp4j/D55031.diff
> > > This DIFF has wrong BASE again.
> > This looks correct. statvfs/fstatvfs are existing interceptors.
> I see, you just updated similar existing one as well.
Yes. It was documented in the description.
Repository:
rCRT Compiler Runtime
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55031/new/
https://reviews.llvm.org/D55031
More information about the llvm-commits
mailing list