[PATCH] D55347: [WebAssembly] TargetStreamer cleanup (NFC)

[Heejin Ahn via Phabricator via llvm-commits]

aheejin marked 3 inline comments as done.
aheejin added inline comments.


================
Comment at: lib/Target/WebAssembly/MCTargetDesc/WebAssemblyTargetStreamer.cpp:82
+void WebAssemblyTargetAsmStreamer::emitGlobalType(const MCSymbolWasm *Sym) {
   assert(Sym->isGlobal());
   OS << "\t.globaltype\t" << Sym->getName() << ", " <<
----------------
For `emitGlobalType` and `emitEventType` we check if the given symbol is global or event type even in AsmStreamer, which supports what I said before: Symbol types are just inherent properties of symbols and should not necessarily be tied to asm case vs. obj case. But if we try to add the same assertion to `WebAssemblyTargetAsmStreamer::emitFunctionType` above (which I did), it fails without my change in this CL that moves `setType(wasm::WASM_SYMBOL_TYPE_FUNCTION)` to AsmPrinter.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55347/new/

https://reviews.llvm.org/D55347