[PATCH] D55117: [HWASAN] Instrument memory intrinsics
Kostya Serebryany via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Dec 7 12:46:21 PST 2018
kcc added a comment.
We do instrument libc on Android, but
- memset&co are still not instrumented because they are written in asm (eugenis@, please confirm)
- hwasan may be useful outside of Android in future. (we actually test it on arm64 linux, and even on x86_64 linux)
So, I still prefer __hwasan_memset (which means that we will also need a run-time test)
eugenis@, thoughts?
================
Comment at: test/Instrumentation/HWAddressSanitizer/mem-intrinsics.ll:3
+
+; CHECK: call i8* @memset
+; CHECK: call i8* @memmove
----------------
please place the checks after their respective "call void @llvm..." lines
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55117/new/
https://reviews.llvm.org/D55117
More information about the llvm-commits
mailing list