[PATCH] D55386: [Sanitizer] Separate FreeBSD interception data structures

David CARLIER via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 7 11:06:50 PST 2018


devnexen marked 2 inline comments as done.
devnexen added inline comments.


================
Comment at: lib/sanitizer_common/sanitizer_platform_limits_freebsd.h:166
+
+#if defined(__x86_64__) && !defined(_LP64)
+  typedef long long __sanitizer_time_t;
----------------
krytarowski wrote:
> krytarowski wrote:
> > is this even possible on FreeBSD? it looks like x32 variation, supported to some level just in gnu
> isn't time_t for FreeBSD 64-bit always?
Nope.


================
Comment at: lib/sanitizer_common/sanitizer_platform_limits_freebsd.h:249
+#if defined(__x86_64__)
+  typedef long long __sanitizer___kernel_off_t;
+#else
----------------
krytarowski wrote:
> FreeBSD should use 64-bit always
Ok.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55386/new/

https://reviews.llvm.org/D55386





More information about the llvm-commits mailing list