[PATCH] D54875: [WebAssembly] Add support for the event section

[Rui Ueyama via Phabricator via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.

LGTM



================
Comment at: wasm/InputFiles.cpp:62
+      "\n       Global Imports : " + Twine(WasmObj->getNumImportedGlobals()) +
+      "\n       Event Imports  : " + Twine(WasmObj->getNumImportedEvents()));
 }
----------------
I think the first column should be aligned to the right, instead of inserting two spaces after "Event Imports", because other rows are aligned that way.


================
Comment at: wasm/WriterUtils.cpp:213-214
+std::string lld::toString(const WasmEventType &Type) {
+  return (Type.Attribute == WASM_EVENT_ATTRIBUTE_EXCEPTION ? "exception"
+                                                           : "unknown");
 }
----------------
nit: you can write this with less indentation.

  if (Type.Attribute == WASM_EVENT_ATTRIBUTE_EXCEPTION)
    return "exception";
  return "unknown";


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54875/new/

https://reviews.llvm.org/D54875