[PATCH] D55391: Don't add unnecessary compiler flags to llvm-config output

Tom Stellard via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 7 09:01:05 PST 2018


tstellar marked an inline comment as done.
tstellar added inline comments.


================
Comment at: tools/llvm-config/CMakeLists.txt:37
+set(LLVM_CFLAGS "${LLVM_DEFINITIONS}")
+set(LLVM_CXXFLAGS "${COMPILE_FLAGS} ${LLVM_DEFINITIONS}")
 set(LLVM_BUILD_SYSTEM cmake)
----------------
mgorny wrote:
> Shouldn't cxxflags also include `-std`?
Yes, I think we need to keep -std=c++11.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55391/new/

https://reviews.llvm.org/D55391





More information about the llvm-commits mailing list