[PATCH] D55227: [DebugInfo] Don't drop dbg.value's of nullptr
Adrian Prantl via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Dec 7 08:41:24 PST 2018
aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.
LGTM if @vsk's question is answered satisfactorily.
================
Comment at: lib/CodeGen/SelectionDAG/InstrEmitter.cpp:739
+ } else if (isa<ConstantPointerNull>(V)) {
+ // Null pointer constants are zero-valued.
+ MIB.addImm(0);
----------------
How about: `//Note: This assumes that all nullptr constants are zero-valued.`
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55227/new/
https://reviews.llvm.org/D55227
More information about the llvm-commits
mailing list