[PATCH] D55345: [AArch64] Refactor the Exynos scheduling predicates

[Andrea Di Biagio via Phabricator via llvm-commits]

andreadb added a comment.

I went through the various changes, and I didn’t find anything that looks obviously wrong. The new predicates look fine to me.

For the tests, I recommend you to use flag `-instruction-table`. As an example, see the RUN line in `test/tools/llvm-mca/X86/BtVer2/resources-avx1.s`.

Flag `-instruction-tables` enables printing the theoretical resource distribution. In my experience, that’s the best way to check the resource consumption of every instruction.
That flag, plus the implicit instruction-info view, is the best combination for tests where you want to verify latency/throughput and resource usage.

It is particularly useful in the presence of instructions that require resolving write variants; you can basically check all the interesting variants.

As soon as tests are added, and you are happy with the latency/throughput/resource usage of instructions, I will be happy to accept this patch.

-Andrea


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55345/new/

https://reviews.llvm.org/D55345