[PATCH] D55435: [AMDGPU] Fix discarded result of addAttribute
Nicolai Hähnle via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Dec 7 08:11:40 PST 2018
nhaehnle added inline comments.
================
Comment at: test/CodeGen/AMDGPU/simplify-libcalls.ll:791
+; GCN-PRELINK: attributes #[[$NOUNWIND]] = { nounwind }
+; GCN-PRELINK: attributes #{{[0-9]+}} = { nounwind readonly }
attributes #0 = { nounwind }
----------------
Shouldn't this be `#[[$NOUNWIND_READONLY]] = { nounwind readonly }`? Or better yet, drop the `$` - I really don't know why the existing checks have $NOUNWIND instead of just NOUNWIND.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55435/new/
https://reviews.llvm.org/D55435
More information about the llvm-commits
mailing list