[PATCH] D42374: [RFC] Add IsFixed field to ISD::ArgFlagsTy

Shiva Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 7 00:52:06 PST 2018


shiva0217 added a comment.
Herald added a subscriber: jocewei.

Hi Alex,
I think it's great that the target description file could determine the argument is fixed or not. In this way, the targets have different ABI behavior for non-fixed arguments could describe by TD files without extra custom c++ codes. It seems that Mips and RISCV already have variable argument test cases to cover the changed. Do other targets involve the changed have variable argument test case? If it's not, could you add the test cases to cover the changed?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D42374/new/

https://reviews.llvm.org/D42374





More information about the llvm-commits mailing list