[PATCH] D28907: [SLP] Fix for PR30787: Failure to beneficially vectorize 'copyable' elements in integer binary ops.

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 7 07:26:38 PST 2018


lebedev.ri added inline comments.


================
Comment at: test/Transforms/SLPVectorizer/X86/invoke.ll:3
+; RUN: opt -S -slp-vectorizer -slp-vectorizer -mcpu=bdver1 < %s | FileCheck %s
+
+target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
----------------
dtemirbulatov wrote:
> dtemirbulatov wrote:
> > lebedev.ri wrote:
> > > Unless this currently crashes, precommit?
> > yes, thanks, I will remove this line.
> Oh, No crash currently on pre-commit, I will remove the whole test.
What i have meant to say is, unless this test file currently causes a crash, it would be best to commit it now, thus the diff will show the diff, and not a whole new test file.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D28907/new/

https://reviews.llvm.org/D28907





More information about the llvm-commits mailing list