[PATCH] D55386: [Sanitizer] Separate FreeBSD interception data structures

[Kamil Rytarowski via Phabricator via llvm-commits]

krytarowski added inline comments.


================
Comment at: lib/sanitizer_common/sanitizer_platform_limits_freebsd.cc:73
+
+#undef INLINE  // to avoid clashes with sanitizers' definitions
+
----------------
The same is needed for NetBSD... can we change the sanitizer defintion in lib/sanitizer_common/sanitizer_internal_defs.h to:

```
#ifndef INLINE
#define INLINE inline
#endif
```


================
Comment at: lib/sanitizer_common/sanitizer_platform_limits_freebsd.h:36
+  extern unsigned struct_stat_sz;
+#if defined(__powerpc64__) || defined(__s390__)
+  const unsigned struct___old_kernel_stat_sz = 0;
----------------
Drop `defined(__s390__)`


================
Comment at: lib/sanitizer_common/sanitizer_platform_limits_freebsd.h:38
+  const unsigned struct___old_kernel_stat_sz = 0;
+#elif !defined(__sparc__)
+  const unsigned struct___old_kernel_stat_sz = 32;
----------------
drop sparc


================
Comment at: lib/sanitizer_common/sanitizer_platform_limits_freebsd.h:166
+
+#if defined(__x86_64__) && !defined(_LP64)
+  typedef long long __sanitizer_time_t;
----------------
is this even possible on FreeBSD? it looks like x32 variation, supported to some level just in gnu


================
Comment at: lib/sanitizer_common/sanitizer_platform_limits_freebsd.h:248
+#endif
+#if defined(__x86_64__) && !defined(_LP64)
+  typedef long long __sanitizer___kernel_off_t;
----------------
Is it possible on FreeBSD?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55386/new/

https://reviews.llvm.org/D55386