[llvm] r348597 - [DAGCombiner] remove explicit calls to AddToWorkList; NFCI

Sanjay Patel via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 7 07:00:56 PST 2018


Author: spatel
Date: Fri Dec  7 07:00:56 2018
New Revision: 348597

URL: http://llvm.org/viewvc/llvm-project?rev=348597&view=rev
Log:
[DAGCombiner] remove explicit calls to AddToWorkList; NFCI

As noted in the post-commit thread for rL347917:
http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20181203/608936.html
...we don't need to repeat these calls because the combiner does it automatically.


Modified:
    llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp

Modified: llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp?rev=348597&r1=348596&r2=348597&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp (original)
+++ llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp Fri Dec  7 07:00:56 2018
@@ -3755,7 +3755,6 @@ SDValue DAGCombiner::hoistLogicOpWithSam
       }
       // logic_op (hand_op X), (hand_op Y) --> hand_op (logic_op X, Y)
       SDValue Logic = DAG.getNode(LogicOpcode, DL, XVT, X, Y);
-      AddToWorklist(Logic.getNode());
       return DAG.getNode(HandOpcode, DL, VT, Logic);
   }
 
@@ -3768,7 +3767,6 @@ SDValue DAGCombiner::hoistLogicOpWithSam
     if (!N0.hasOneUse() || !N1.hasOneUse())
       return SDValue();
     SDValue Logic = DAG.getNode(LogicOpcode, DL, XVT, X, Y);
-    AddToWorklist(Logic.getNode());
     return DAG.getNode(HandOpcode, DL, VT, Logic, N0.getOperand(1));
   }
 
@@ -3778,7 +3776,6 @@ SDValue DAGCombiner::hoistLogicOpWithSam
     if (!N0.hasOneUse() || !N1.hasOneUse())
       return SDValue();
     SDValue Logic = DAG.getNode(LogicOpcode, DL, XVT, X, Y);
-    AddToWorklist(Logic.getNode());
     return DAG.getNode(HandOpcode, DL, VT, Logic);
   }
 
@@ -3794,7 +3791,6 @@ SDValue DAGCombiner::hoistLogicOpWithSam
     // Input types must be integer and the same.
     if (XVT.isInteger() && XVT == Y.getValueType()) {
       SDValue Logic = DAG.getNode(LogicOpcode, DL, XVT, X, Y);
-      AddToWorklist(Logic.getNode());
       return DAG.getNode(HandOpcode, DL, VT, Logic);
     }
   }
@@ -3835,7 +3831,6 @@ SDValue DAGCombiner::hoistLogicOpWithSam
     if (N0.getOperand(1) == N1.getOperand(1) && ShOp.getNode()) {
       SDValue Logic = DAG.getNode(LogicOpcode, DL, VT,
                                   N0.getOperand(0), N1.getOperand(0));
-      AddToWorklist(Logic.getNode());
       return DAG.getVectorShuffle(VT, DL, Logic, ShOp, SVN0->getMask());
     }
 
@@ -3849,7 +3844,6 @@ SDValue DAGCombiner::hoistLogicOpWithSam
     if (N0.getOperand(0) == N1.getOperand(0) && ShOp.getNode()) {
       SDValue Logic = DAG.getNode(LogicOpcode, DL, VT, N0.getOperand(1),
                                   N1.getOperand(1));
-      AddToWorklist(Logic.getNode());
       return DAG.getVectorShuffle(VT, DL, ShOp, Logic, SVN0->getMask());
     }
   }




More information about the llvm-commits mailing list