[PATCH] D55423: [LLD][ELF] - A fix for "linker script assignment loses relative nature of section" bug.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 7 05:16:18 PST 2018


grimar added a comment.

Note that for some targets we already call the `assignAddresses` at least twice.
That happens because `maybeAddThunks` calls it.

At first, I thought to reuse `maybeAddThunks`, it could always run if `Script->HasSectionsCommand` set,
but it is perhaps not the right place, so I added ``assignAddresses` to `Writer<ELFT>::run()`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55423/new/

https://reviews.llvm.org/D55423





More information about the llvm-commits mailing list