[PATCH] D55316: [CMake] Add support for NO_INSTALL_RPATH argument in llvm_add_library()

[Stefan Gränitz via Phabricator via llvm-commits]

sgraenitz marked 2 inline comments as done.
sgraenitz added inline comments.


================
Comment at: cmake/modules/AddLLVM.cmake:458
 
+  if(NOT ARG_NO_INSTALL_RPATH)
+    if(ARG_MODULE OR ARG_SHARED)
----------------
aprantl wrote:
> Any kind of comment that we could add here that explains why this is happening? This looks quite mysterious to the casual reader otherwise :-)
Good point, thanks. Added short comment to the function description.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55316/new/

https://reviews.llvm.org/D55316