[PATCH] D55407: [COFF]Correct .eh_frame name, let llvm tools such as llvm-dwarfdump can dump .eh_frame info

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 7 01:00:53 PST 2018


mstorsjo added a comment.

In D55407#1322668 <https://reviews.llvm.org/D55407#1322668>, @SquallATF wrote:

> Writing this test case is too difficult for me.


I'd suggest something like this: Link an absolute minimal executable with the properties you want (a section named `.eh_fram`). Dump this to yaml with the obj2yaml tool. Then create a test e.g. like test/tools/llvm-dwarfdump/uuid.yaml, which consists of the dumped yaml and a RUN line at the start, which runs yaml2obj to convert it back to an executable, and runs llvm-dwarfdump on it, and a CHECK line which checks for some piece of information. In this case it's enough to just check for any information that dwarfdump shows when it found the `.eh_fram` but didn't show before (e.g. an example of what value you get from fixing this issue).


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55407/new/

https://reviews.llvm.org/D55407





More information about the llvm-commits mailing list