[PATCH] D55211: [LLD][ELF] - Support discarding the .dynamic section.

[George Rimar via Phabricator via llvm-commits]

grimar added a comment.

In D55211#1321551 <https://reviews.llvm.org/D55211#1321551>, @peter.smith wrote:

> I've had a chance to check through this and other 3 patches in series. If we are intending to do the minimum to stop the linker from crashing and assume the user knows what they are doing when they do this, then these look correct to me. I think these changes are important for use of LLD to link the linux kernel.
>
> May I suggest a 4th patch with a test case that shows the scenario from the kernel. This depends on this, D55215 <https://reviews.llvm.org/D55215> and D55218 <https://reviews.llvm.org/D55218>. It illustrates the intent behind the ability to discard these sections. I've made a proposal here:
>
>  


Thanks for checking, Peter! I have no objections to land such patch to demonstrate we still producing the expected output when all these sections are discarded at once.
I would have few comments about the test though, so would suggest to push it on review if/when we decide to land these 3.

Rui, what do you think?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55211/new/

https://reviews.llvm.org/D55211