[PATCH] D55407: [COFF]Correct .eh_frame name, let llvm tools such as llvm-dwarfdump can dump .eh_frame info

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 6 23:13:32 PST 2018


mstorsjo added reviewers: rnk, ruiu, pcc.
mstorsjo added a comment.

For backstory/reference: In lld, we choose to store the name of the section `.eh_frame` truncated as `.eh_fram` instead of storing the full name in the string table, to allow libunwind to find the section introspectively at runtime. (The string table, where long section names are stored, isn't loaded at runtime.)

I'm a little undecided about this. For one, I think it might be better to keep `COFFObjectFile` truthful and actually return the real section name, and have code that looks for the `.eh_frame` section (in llvm-dwarfdump?) accept anything like `.eh_fram*` (at least for COFF files). But I imagine that llvm-dwardump is using the higher level abstracted object API that abstracts away the object file format specific details - and adding coff specific code there isn't very neat either.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55407/new/

https://reviews.llvm.org/D55407





More information about the llvm-commits mailing list