[PATCH] D55386: [Sanitizer] Separate FreeBSD interception data structures

[Kamil Rytarowski via Phabricator via llvm-commits]

krytarowski added inline comments.


================
Comment at: lib/sanitizer_common/sanitizer_platform_limits_freebsd.cc:12
+//
+// Sizes and layouts of platform-specific NetBSD data structures.
+//===----------------------------------------------------------------------===//
----------------
NetBSD -> FreeBSD


================
Comment at: lib/sanitizer_common/sanitizer_platform_limits_freebsd.cc:80
+# if defined(__mips64) || defined(__aarch64__) || defined(__arm__)
+#  include <asm/ptrace.h>
+#  ifdef __arm__
----------------
Is this a valid FreeBSD header?


================
Comment at: lib/sanitizer_common/sanitizer_platform_limits_freebsd.cc:434
+CHECK_STRUCT_SIZE_AND_OFFSET(sigaction, sa_mask);
+#if !defined(__s390x__)
+// On s390x glibc 2.19 and earlier sa_flags was unsigned long, and sa_resv
----------------
This is Linux specific, drop.


================
Comment at: lib/sanitizer_common/sanitizer_platform_limits_posix.cc:520
   unsigned IOCTL_TIOCSWINSZ = TIOCSWINSZ;
-#if ((SANITIZER_LINUX || SANITIZER_FREEBSD) && !SANITIZER_ANDROID)
+#if (SANITIZER_LINUX && !SANITIZER_ANDROID)
   unsigned IOCTL_SIOCGETSGCNT = SIOCGETSGCNT;
----------------
() not needed


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55386/new/

https://reviews.llvm.org/D55386