[PATCH] D55390: [llvm-tapi] Don't override SequenceTraits for std::string

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 6 15:23:11 PST 2018


sbc100 accepted this revision.
sbc100 added a comment.
This revision is now accepted and ready to land.

Thanks.  lgtm



================
Comment at: llvm/lib/TextAPI/ELF/TBEHandler.cpp:148
+  static QuotingType mustQuote(StringRef) { return QuotingType::None; }
 };
 
----------------
Do you need this template?  Isn't it enough to simply declare it as LLVM_YAML_IS_FLOW_SEQUENCE_VECTOR? 




Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55390/new/

https://reviews.llvm.org/D55390





More information about the llvm-commits mailing list