[PATCH] D54313: [compiler-rt][builtins][PowerPC] Add floattitf builtin compiler-rt method support for PowerPC

[Robert Enenkel via Phabricator via llvm-commits]

renenkel requested changes to this revision.
renenkel added a comment.
This revision now requires changes to proceed.

I think the use of the DD.h include file makes the code confusing, for several reasons:  1. It requires you to look at two files; 2. An additional assignment is required to interpret the component doubles of the long double as 64-bit ints.  I suggest you retain the original form of the union, for example:

#define HI 0
#define LO 1
// Use enum HILO {HI=0, LO=1}; if LLVM style discourages #define

union {long double ld; double d[2]; uint64_t ui[2];} uld;

uld.ld = ld;
// Now you can access any of them easily...
uld.d[HI]
uld.d[LO]
uld.ui[HI]
uld.ui{LO]


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54313/new/

https://reviews.llvm.org/D54313