[PATCH] D55235: llvm-objcopy: Improve/simplify llvm::Error handling during notes iteration
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Dec 6 12:59:11 PST 2018
MaskRay added inline comments.
================
Comment at: include/llvm/Object/ELFTypes.h:664
: RemainingSize(Size), Err(&Err) {
+ consumeError(std::move(Err));
assert(Start && "ELF note iterator starting at NULL");
----------------
Why does here use `consumeError` but not `ErrorAsOutParameter`?
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55235/new/
https://reviews.llvm.org/D55235
More information about the llvm-commits
mailing list