[PATCH] D55347: [WebAssembly] TargetStreamer cleanup (NFC)

[Sam Clegg via Phabricator via llvm-commits]

sbc100 added inline comments.


================
Comment at: lib/Target/WebAssembly/WebAssemblyAsmPrinter.cpp:115
+        Sym->setModuleName(Name);
         getTargetStreamer()->emitImportModule(Sym, Name);
       }
----------------
I think it might make sense to continue to have `emitImportModule` to one thing for the asm case and the other for the binary streamer.   Calling setModuleName() is clearly not needed for the asm writer so why do it?

Perhaps the difficulty comes from the fact that WebAssemblyTargetWasmStreamer wants to set attributes on the symbols when maybe it should be storing this "extra" symbol information that only it requires in a side data structure?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55347/new/

https://reviews.llvm.org/D55347