[PATCH] D54143: [WIP, RISCV] Generate address sequences suitable for mcmodel=medium

Lewis Revill via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 6 10:44:12 PST 2018


lewis-revill marked 2 inline comments as done.
lewis-revill added inline comments.


================
Comment at: lib/Target/RISCV/RISCVISelLowering.cpp:335
 
+SDValue getTargetNode(GlobalAddressSDNode *N, SDLoc DL, EVT Ty,
+                      SelectionDAG &DAG, unsigned Flags) {
----------------
rogfer01 wrote:
> Can these helper functions be made `static`?
They certainly can, thanks!


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54143/new/

https://reviews.llvm.org/D54143





More information about the llvm-commits mailing list