[PATCH] D55297: [DemandedBits][BDCE] Support vectors of integers

Hal Finkel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 6 10:40:23 PST 2018


hfinkel accepted this revision.
hfinkel added a comment.
This revision is now accepted and ready to land.

This LGTM. However, please, in llvm/Analysis/DemandedBits.h, document what this means for vectors (that it treats all elements the same and returns a mask of the scalar size). You might expand on the comment:

  /// Return the bits demanded from instruction I.
  APInt getDemandedBits(Instruction *I);


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55297/new/

https://reviews.llvm.org/D55297





More information about the llvm-commits mailing list