[PATCH] D53965: IR: Add fp operations to atomicrmw

[Matt Arsenault via Phabricator via llvm-commits]

arsenm marked 2 inline comments as done.
arsenm added inline comments.


================
Comment at: include/llvm/IR/Instructions.h:813
 
+  bool isFloatingPointOperation() const {
+    return isFPOperation(getOperation());
----------------
jyknight wrote:
> Unused?
It's not used here, but included for completeness since all of the other instructions do this (e.g. ICmpInst::getUnsignedPredicate


================
Comment at: lib/CodeGen/AtomicExpandPass.cpp:1522-1523
     return {};
+  default:
+    llvm_unreachable("unhandled operation");
   }
----------------
jyknight wrote:
> This isn't great. And I see in your next patch you fix it, but splitting that to another patch doesn't make sense.
I'd disagree, since usually with IR changes there's a split to add the minimum support to the assembler and bitcode before making them functional as a separate commit. This is just needed to quiet the covered switch warning


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D53965/new/

https://reviews.llvm.org/D53965