[PATCH] D55347: [WebAssembly] TargetStreamer cleanup (NFC)
Sam Clegg via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Dec 6 08:31:41 PST 2018
sbc100 added inline comments.
================
Comment at: lib/Target/WebAssembly/MCTargetDesc/WebAssemblyTargetStreamer.cpp:137
- // Symbol already has its arguments and result set.
- Symbol->setType(wasm::WASM_SYMBOL_TYPE_FUNCTION);
-}
----------------
We have two different streamers `WebAssemblyTargetWasmStreamer` and `WebAssemblyTargetAsmStreamer`. I seems that this code is only needed for the object file streamer so moving it out into common code is actually a semantic change.
Can you revert this part or at least put it in separate change so that this one can be a simple NFC?
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55347/new/
https://reviews.llvm.org/D55347
More information about the llvm-commits
mailing list