[PATCH] D55279: [RISCV] Support assembling %got_pcrel_hi operator
James Clarke via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Dec 6 05:47:42 PST 2018
jrtc27 added a comment.
In D55279#1320388 <https://reviews.llvm.org/D55279#1320388>, @lewis-revill wrote:
> Could you correct the error message for `InvalidUImm20AUIPC` in `RISCVAsmParser` to include this new operator & change `rv32i-invalid.s` appropriately? When I did this I also added a test line in `rv32i-valid.s` but it's mostly testing the same thing as the test in `relocations.s`. Maybe you want to add that as well for completeness though.
Ah thanks for catching that.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55279/new/
https://reviews.llvm.org/D55279
More information about the llvm-commits
mailing list