[PATCH] D55314: AMDGPU: Turn on the DPP combiner by default

Valery Pykhtin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 6 05:07:35 PST 2018


vpykhtin added a comment.

In D55314#1321167 <https://reviews.llvm.org/D55314#1321167>, @hakzsam wrote:

> Hi,
>
> This change breaks most of the subgroups tests with RADV (ie. dEQP-VK.subgroups.arithmetic.*).
>
> Any reasons why you enabled it by default? Looks like it now triggers a new bug in the AMDGPU backend.
>
> Thanks!


Hi,

this is awaited feature and other reason is to detect a situation such yours. I think it's better to turn it off and reproduce the failures: how can I do this?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55314/new/

https://reviews.llvm.org/D55314





More information about the llvm-commits mailing list