[PATCH] D55234: Do not use a hash table to uniquify mergeable strings.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 6 00:51:38 PST 2018


grimar added a comment.

In D55234#1320483 <https://reviews.llvm.org/D55234#1320483>, @ruiu wrote:

> I ran lld with a few more large programs, and here is the result.
>
>   Size   Before  After  
>   6.1GB  20.16s  19.15s (-4.98%)
>   3.8GB  56.27s  53.38s (-5.14%)
>   2.5GB  32.65s  32.56s (+0.28%)
>   
>
> Since large programs take time to link, and in order to reduce noise I need to run it many times, it is not easy to run lld on many large programs, but I believe you can still see a pattern. At least I think I can say that removing the hash table is not bad.


Looks good, thanks for the numbers.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55234/new/

https://reviews.llvm.org/D55234





More information about the llvm-commits mailing list