[PATCH] D55184: [gn build] Process .def.in files in llvm/include/Config and that to add a build file for llvm/lib/Target

[Petr Hosek via Phabricator via llvm-commits]

phosek accepted this revision.
phosek added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/utils/gn/secondary/llvm/include/llvm/Config/BUILD.gn:368
+template("write_target_def_file") {
+  assert(defined(invoker.key))
+  assert(defined(invoker.value))
----------------
Can you please also provide an error message?


================
Comment at: llvm/utils/gn/secondary/llvm/include/llvm/Config/BUILD.gn:398
+}
+write_target_def_file("AsmParsers.def") {
+  key = "LLVM_ENUM_ASM_PARSERS"
----------------
Can you put spaces between each target to visually separate them?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55184/new/

https://reviews.llvm.org/D55184