[PATCH] D55174: Fix bug 8220 - llvm-config: Only keep flags starting by -I, -D & -stdfor --cflags, --cxxflags & --ldflags

[Tom Stellard via Phabricator via llvm-commits]

tstellar added a comment.

I only mentioned -fno-rtti specifically because this is something that llvm-config already knows about.  I also don't have knowledge of all the possible flags that might need to be filtered.

After thinking about this more, I don't think we should pass through any user specific compiler flags at all.  We should limit it to -I and -D flags added by the build system or compiler flags added by llvm specific options, like LLVM_ENABLE_RTTI.  I think keeping upstream simple and having package maintainers filter-in options as needed to llvm-config makes more sense, because package maintainers know the flags that they are using and are in the best position to decide which flags users should be using too.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55174/new/

https://reviews.llvm.org/D55174