[PATCH] D55335: [RISCV, WIP] Support assembling @plt symbol operands

Lewis Revill via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 5 14:00:03 PST 2018


lewis-revill added a comment.

I agree that it would be good to prevent other instructions using '@plt' (this was mentioned in the original MC+codegen patch). The difficulty is that `getParser().parseIdentifier` consumes the '@' as a valid character. This would mean that the new `parseBareSymbolOrPLT` would be trivial to do from what I have implemented here but a check would have to be added in `parseBareSymbol` for whether the identifier ends in '@plt'. The other possibility is to keep the logic in 'parseBareSymbol' and if it is an identifier with '@plt' then it should check `Operands[0]` for 'call' or 'tail', which doesn't seem very nice to me.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55335/new/

https://reviews.llvm.org/D55335





More information about the llvm-commits mailing list