[PATCH] D54719: [Intrinsic] Signed Fixed Point Multiplication Intrinsic

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp:2568
+  SDValue RHS = N->getOperand(1);
+  unsigned Scale = cast<ConstantSDNode>(N->getOperand(2))->getZExtValue();
+  if (!Scale) {
----------------
Just get N->getConstantOperandVal(2)?


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp:2599
+  SDValue ResultHH = Result[3];
+  ResultLL = DAG.getNode(ISD::SRL, dl, NVT, ResultLL, SRLAmnt);
+
----------------
This result is only used by one of the 2 ifs below. Should it be pulled into that if.

Can you add a comment to describe what's happening here? 


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54719/new/

https://reviews.llvm.org/D54719