[PATCH] D52416: Allow FP types for atomicrmw xchg

[James Y Knight via Phabricator via llvm-commits]

jyknight added a comment.

Looks reasonable.

Perhaps add support for pointer types too? Supporting the same set of types for load, store, xchg, and cmpxchg (eventually) would seem sensible.



================
Comment at: lib/CodeGen/AtomicExpandPass.cpp:500
+
+  bool NeedBitcast = OrigTy->isFloatingPointTy();
+  if (NeedBitcast) {
----------------
Add a comment here that this code can go away if the cmpxchg instruction adds support for floating point types.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D52416/new/

https://reviews.llvm.org/D52416