[PATCH] D55309: ThinLTO: Do not import debug info for imported global constants

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.

LGTM to address regression, especially since the debug info already isn't maintained for global variables that are const propagated. David, as a follow on it would be good to understand if/when there are cases where the debug info should be imported for these variables (i.e. if they aren't in fact constant propagated after internalization).



================
Comment at: lib/Linker/IRMover.cpp:1065
     ValueMap.MD()[CU->getRawRetainedTypes()].reset(nullptr);
+    ValueMap.MD()[CU->getRawGlobalVariables()].reset(nullptr);
 
----------------
Please add a comment here (the old one that was removed isn't quite accurate now, but could probably be modified).


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55309/new/

https://reviews.llvm.org/D55309