[llvm] r348391 - [MachineOutliner][NFC] Make getters in MachineOutliner.h const

Jessica Paquette via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 5 10:12:52 PST 2018


Author: paquette
Date: Wed Dec  5 10:12:52 2018
New Revision: 348391

URL: http://llvm.org/viewvc/llvm-project?rev=348391&view=rev
Log:
[MachineOutliner][NFC] Make getters in MachineOutliner.h const

Just some refactoring. A few of the getters in OutlinedFunction weren't const.

Modified:
    llvm/trunk/include/llvm/CodeGen/MachineOutliner.h

Modified: llvm/trunk/include/llvm/CodeGen/MachineOutliner.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/CodeGen/MachineOutliner.h?rev=348391&r1=348390&r2=348391&view=diff
==============================================================================
--- llvm/trunk/include/llvm/CodeGen/MachineOutliner.h (original)
+++ llvm/trunk/include/llvm/CodeGen/MachineOutliner.h Wed Dec  5 10:12:52 2018
@@ -202,19 +202,19 @@ public:
 
   /// Return the number of bytes it would take to outline this
   /// function.
-  unsigned getOutliningCost() {
+  unsigned getOutliningCost() const {
     unsigned CallOverhead = 0;
-    for (std::shared_ptr<Candidate> &C : Candidates)
+    for (const std::shared_ptr<Candidate> &C : Candidates)
       CallOverhead += C->getCallOverhead();
     return CallOverhead + SequenceSize + FrameOverhead;
   }
 
   /// Return the size in bytes of the unoutlined sequences.
-  unsigned getNotOutlinedCost() { return OccurrenceCount * SequenceSize; }
+  unsigned getNotOutlinedCost() const { return OccurrenceCount * SequenceSize; }
 
   /// Return the number of instructions that would be saved by outlining
   /// this function.
-  unsigned getBenefit() {
+  unsigned getBenefit() const {
     unsigned NotOutlinedCost = getNotOutlinedCost();
     unsigned OutlinedCost = getOutliningCost();
     return (NotOutlinedCost < OutlinedCost) ? 0
@@ -233,7 +233,7 @@ public:
     for (Candidate &C : Cands)
       Candidates.push_back(std::make_shared<outliner::Candidate>(C));
 
-    unsigned B = getBenefit();
+    const unsigned B = getBenefit();
     for (std::shared_ptr<Candidate> &C : Candidates)
       C->Benefit = B;
   }




More information about the llvm-commits mailing list