[PATCH] D55305: [RISCV, WIP] Add initial lowering of global TLS addresses

Wed Dec 5 09:26:11 PST 2018

lewis-revill added a comment.

In D55305#1319651 <https://reviews.llvm.org/D55305#1319651>, @jrtc27 wrote:

> I'd rather see all the local-exec support moved into D55306 <https://reviews.llvm.org/D55306>; I don't think it makes much sense to add things here that don't yet work. Alternatively, to avoid lines that are then going to be modified again in D55306 <https://reviews.llvm.org/D55306>, you could merge the two? There aren't many extra changes in D55306 <https://reviews.llvm.org/D55306>.

Yes sorry about that, I can do that.

In D55305#1319850 <https://reviews.llvm.org/D55305#1319850>, @asb wrote:

> Thanks for sharing this patch series Lewis. As it happens @luismarques has been finishing off his own implementation of TLS support which this unfortunately clashes with. The upside is that we're in a good position to review this work!
>
> Could you please refactor the patches so that MC layer changes occur separately to codegen. e.g. having one patch that adds the MC layer changes for for TLS and a second which adds the codegen changes.

OK, I'll look at doing that and incorporating existing MC patches where they exist.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55305/new/

https://reviews.llvm.org/D55305